Skip to content

style(id): reformat with pinned treefmt to restore format checks (#5459) - #6461

Merged
dezren39 merged 1 commit into
mainfrom
fix/5459-main-tier-checks
Nov 6, 2026
Merged

dezren39 merged 1 commit into
mainfrom
fix/5459-main-tier-checks

Conversation

@dezren39

@dezren39 dezren39 commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Partial fix for #5459 (main-broken, id workflow @455f3bb). Diagnosis from the failing run 41815275218's logs — the breakage is four separate legs, not one:

  1. Format drift — rustfmt/cargo-fmt/treefmt/prettier checks red on accumulated unformatted merges (PR CI is disabled; main-tier is the first place checks run). This PR fixes this leg: the tree reformatted with the flake's pinned treefmt (8 files, pure formatting: 6 Rust files, 1 Markdown, 1 shell script).
  2. Clippy restriction lints — unwrap_used/expect_used/panic were set to deny in pkgs/id/Cargo.toml on 2026-11-02 (PR fix(design-code): repoint :18745 legs to antigravity-direct :18751 (#1413, unblocks opencode#1409) #4626) and the tree was never brought into conformance: 571 deny-level sites at HEAD (20 in the id lib target, 551 in its lib-test target; id-core has exactly 1). Split into its own campaign issue with full evidence — too large and judgment-bearing for this PR.
  3. test-shard-0 — the CI failure was runner disk exhaustion (No space left on device mid-compile), not code. Verified green on the laptop at this tree.
  4. Cache/rate-limit noise in the clippy job (magic-nix-cache 418 + GitHub API ResourceExhausted) — transient.

Verification (laptop, this tree, pkgs/id flake checks):

  • rustfmt-check, cargo-fmt-check, prettier-check, treefmt-check: PASS after this change (all four failed before it).
  • biome-check, web-lint: PASS (already green at HEAD).
  • test-shard-0, test-unit: PASS.
  • clippy-lint: still red — split out per leg 2 above.

Deliberately does NOT carry the "Fixes #5459" closing keyword: #5459 stays open as the breakage holder until the clippy leg lands.

Filed from the dead-at-cap evaluation (task 9553's triage, completed by hand after 24 claim-evaporation cycles).


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 6, 2026 07:49
@dezren39
dezren39 merged commit 97648e2 into main Nov 6, 2026
4 checks passed
@dezren39
dezren39 deleted the fix/5459-main-tier-checks branch November 6, 2026 07:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T07:50:49.586371Z 4032112 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main-broken: developing-today/code id @455f3bb — basic: nix flake check (biome-check)

1 participant